lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 689/917] vdpa/mlx5: Fix clearing of VIRTIO_NET_F_MAC feature bit
    Date
    From: Parav Pandit <parav@nvidia.com>

    [ Upstream commit ef76eb83a17e803a66b64ac95b36ae48b3d17c22 ]

    Cited patch in the fixes tag clears the features bit during reset.
    mlx5 vdpa device feature bits are static decided by device capabilities.
    These feature bits (including VIRTIO_NET_F_MAC) are initialized during
    device addition time.

    Clearing features bit in reset callback cleared the VIRTIO_NET_F_MAC. Due
    to this, MAC address provided by the device is not honored.

    Fix it by not clearing the static feature bits during reset.

    Fixes: 0686082dbf7a ("vdpa: Add reset callback in vdpa_config_ops")
    Signed-off-by: Parav Pandit <parav@nvidia.com>
    Reviewed-by: Eli Cohen <elic@nvidia.com>
    Link: https://lore.kernel.org/r/20211026175519.87795-7-parav@nvidia.com
    Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    Acked-by: Jason Wang <jasowang@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/vdpa/mlx5/net/mlx5_vnet.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
    index bd56de7484dcb..ae85d2dd6eb76 100644
    --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
    +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
    @@ -2192,7 +2192,6 @@ static int mlx5_vdpa_reset(struct vdpa_device *vdev)
    clear_vqs_ready(ndev);
    mlx5_vdpa_destroy_mr(&ndev->mvdev);
    ndev->mvdev.status = 0;
    - ndev->mvdev.mlx_features = 0;
    memset(ndev->event_cbs, 0, sizeof(ndev->event_cbs));
    ndev->mvdev.actual_features = 0;
    ++mvdev->generation;
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 01:34    [W:4.063 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site