Messages in this thread | | | Date | Mon, 15 Nov 2021 14:38:28 +0800 | Subject | Re: [RESEND PATCH v2 11/11] dt-bindings: convert qcom,spmi-pmic-arb binding to YAML format | From | Fenglin Wu <> |
| |
On 2021/11/15 8:16, Fenglin Wu wrote: > > On 2021/11/12 21:48, Rob Herring wrote: >> On Fri, 12 Nov 2021 12:24:19 +0800, Fenglin Wu wrote: >>> Convert the SPMI PMIC arbiter documentation to JSON/yaml. >>> >>> Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com> >>> --- >>> .../bindings/spmi/qcom,spmi-pmic-arb.txt | 67 ----------- >>> .../bindings/spmi/qcom,spmi-pmic-arb.yaml | 122 >>> +++++++++++++++++++++ >>> 2 files changed, 122 insertions(+), 67 deletions(-) >>> delete mode 100644 >>> Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt >>> create mode 100644 >>> Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml >>> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml: >> properties:interrupt-names: 'const' should not be valid under >> {'enum': ['const', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', >> 'minimum', 'maximum', 'multipleOf', 'pattern']} >> hint: Scalar and array keywords cannot be mixed >> from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml: >> properties:reg-names: {'minItems': 3, 'maxItems': 5, 'items': >> [{'const': 'core'}, {'const': 'intr'}, {'const': 'cnfg'}, {'const': >> 'chnls'}, {'const': 'obsrvr'}]} should not be valid under >> {'required': ['maxItems']} >> hint: "maxItems" is not needed with an "items" list >> from schema $id: http://devicetree.org/meta-schemas/items.yaml# >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml: >> ignoring, error in schema: properties: interrupt-names >> warning: no schema found in file: >> ./Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.example.dt.yaml: >> spmi@fc4cf000: reg: [[4232900608, 4096], [4232884224, 4096], >> [4232880128, 4096]] is too long >> From schema: >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spmi/spmi.yaml >> Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.example.dt.yaml:0:0: >> /example-0/spmi@fc4cf000: failed to match any schema with compatible: >> ['qcom,spmi-pmic-arb'] >> >> doc reference errors (make refcheckdocs): >> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt: >> Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt >> >> See https://patchwork.ozlabs.org/patch/1554141 >> >> This check can fail if there are any dependencies. The base for a patch >> series is generally the most recent rc1. >> >> If you already ran 'make dt_binding_check' and didn't see the above >> error(s), then make sure 'yamllint' is installed and dt-schema is up to >> date: >> >> pip3 install dtschema --upgrade >> >> Please check and re-submit. > I actually ran "make dt-binding-check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/qcom,spmi-pmic-arb.txt" > and confirmed there was no error or warning before pushing the change. > Anyway I will follow > your steps here andcheck it again, if any changes is required, I will > have them updated it > in next patchset. > Thanks I could see the same warning message after installed 'yamllint'. I will fix this and re-submit. Thanks
| |