lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 461/917] mt76: mt7915: fix info leak in mt7915_mcu_set_pre_cal()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 3924715ffe5e064a85f56490f77b7b2084230800 ]

    Zero out all the unused members of "req" so that we don't disclose
    stack information.

    Fixes: 495184ac91bb ("mt76: mt7915: add support for applying pre-calibration data")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Felix Fietkau <nbd@nbd.name>
    Signed-off-by: Felix Fietkau <nbd@nbd.name>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/mediatek/mt76/mt7915/mcu.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
    index 2f30047bd80f2..caf2033c5c17e 100644
    --- a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
    +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
    @@ -3481,7 +3481,7 @@ static int mt7915_mcu_set_pre_cal(struct mt7915_dev *dev, u8 idx,
    u8 idx;
    u8 rsv[4];
    __le32 len;
    - } req;
    + } req = {};
    struct sk_buff *skb;

    skb = mt76_mcu_msg_alloc(&dev->mt76, NULL, sizeof(req) + len);
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 01:33    [W:4.034 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site