lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 440/917] drm/msm: fix potential NULL dereference in cleanup
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 027d052a36e56789a2134772bacb4fd0860f03a3 ]

    The "msm_obj->node" list needs to be initialized earlier so that the
    list_del() in msm_gem_free_object() doesn't experience a NULL pointer
    dereference.

    Fixes: 6ed0897cd800 ("drm/msm: Fix debugfs deadlock")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Link: https://lore.kernel.org/r/20211013081133.GF6010@kili
    Signed-off-by: Rob Clark <robdclark@chromium.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/msm/msm_gem.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
    index 22308a1b66fc3..fd398a4eaf46e 100644
    --- a/drivers/gpu/drm/msm/msm_gem.c
    +++ b/drivers/gpu/drm/msm/msm_gem.c
    @@ -1132,6 +1132,7 @@ static int msm_gem_new_impl(struct drm_device *dev,
    msm_obj->flags = flags;
    msm_obj->madv = MSM_MADV_WILLNEED;

    + INIT_LIST_HEAD(&msm_obj->node);
    INIT_LIST_HEAD(&msm_obj->vmas);

    *obj = &msm_obj->base;
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 01:33    [W:2.534 / U:0.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site