lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 566/917] staging: r8188eu: fix memory leak in rtw_set_key
    Date
    From: Pavel Skripkin <paskripkin@gmail.com>

    [ Upstream commit 393db0f6827f96054a769ba3a38aa382d137d3c7 ]

    Before returning with an error we should free allocated buffers, since
    they are not assigned to anywhere.

    Fixes: 15865124feed ("staging: r8188eu: introduce new core dir for RTL8188eu driver")
    Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
    Link: https://lore.kernel.org/r/ee783fbb71abb549505b84542223be7a7c905eea.1630692375.git.paskripkin@gmail.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/staging/r8188eu/core/rtw_mlme.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r8188eu/core/rtw_mlme.c
    index 1115ff5d865ad..bd991d7ed8090 100644
    --- a/drivers/staging/r8188eu/core/rtw_mlme.c
    +++ b/drivers/staging/r8188eu/core/rtw_mlme.c
    @@ -1722,6 +1722,8 @@ int rtw_set_key(struct adapter *adapter, struct security_priv *psecuritypriv, in
    psetkeyparm->grpkey = 1;
    break;
    default:
    + kfree(psetkeyparm);
    + kfree(pcmd);
    res = _FAIL;
    goto exit;
    }
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 01:11    [W:4.059 / U:0.324 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site