lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 624/917] usb: gadget: hid: fix error code in do_config()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 68e7c510fdf4f6167404609da52e1979165649f6 ]

    Return an error code if usb_get_function() fails. Don't return success.

    Fixes: 4bc8a33f2407 ("usb: gadget: hid: convert to new interface of f_hid")
    Acked-by: Felipe Balbi <balbi@kernel.org>
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Link: https://lore.kernel.org/r/20211011123739.GC15188@kili
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/gadget/legacy/hid.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/usb/gadget/legacy/hid.c b/drivers/usb/gadget/legacy/hid.c
    index 5b27d289443fe..3912cc805f3af 100644
    --- a/drivers/usb/gadget/legacy/hid.c
    +++ b/drivers/usb/gadget/legacy/hid.c
    @@ -99,8 +99,10 @@ static int do_config(struct usb_configuration *c)

    list_for_each_entry(e, &hidg_func_list, node) {
    e->f = usb_get_function(e->fi);
    - if (IS_ERR(e->f))
    + if (IS_ERR(e->f)) {
    + status = PTR_ERR(e->f);
    goto put;
    + }
    status = usb_add_function(c, e->f);
    if (status < 0) {
    usb_put_function(e->f);
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 01:11    [W:4.079 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site