lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 550/917] net: phylink: avoid mvneta warning when setting pause parameters
    Date
    From: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

    [ Upstream commit fd8d9731bcdfb22d28e45bce789bcb211c868c78 ]

    mvneta does not support asymetric pause modes, and it flags this by the
    lack of AsymPause in the supported field. When setting pause modes, we
    check that pause->rx_pause == pause->tx_pause, but only when pause
    autoneg is enabled. When pause autoneg is disabled, we still allow
    pause->rx_pause != pause->tx_pause, which is incorrect when the MAC
    does not support asymetric pause, and causes mvneta to issue a warning.

    Fix this by removing the test for pause->autoneg, so we always check
    that pause->rx_pause == pause->tx_pause for network devices that do not
    support AsymPause.

    Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
    Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/phy/phylink.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
    index 5a58c77d00022..7ec3105010ac1 100644
    --- a/drivers/net/phy/phylink.c
    +++ b/drivers/net/phy/phylink.c
    @@ -1727,7 +1727,7 @@ int phylink_ethtool_set_pauseparam(struct phylink *pl,
    return -EOPNOTSUPP;

    if (!phylink_test(pl->supported, Asym_Pause) &&
    - !pause->autoneg && pause->rx_pause != pause->tx_pause)
    + pause->rx_pause != pause->tx_pause)
    return -EINVAL;

    pause_state = 0;
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 01:10    [W:5.627 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site