lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 519/917] libbpf: Fix off-by-one bug in bpf_core_apply_relo()
    Date
    From: Andrii Nakryiko <andrii@kernel.org>

    [ Upstream commit de5d0dcef602de39070c31c7e56c58249c56ba37 ]

    Fix instruction index validity check which has off-by-one error.

    Fixes: 3ee4f5335511 ("libbpf: Split bpf_core_apply_relo() into bpf_program independent helper.")
    Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
    Signed-off-by: Alexei Starovoitov <ast@kernel.org>
    Link: https://lore.kernel.org/bpf/20211025224531.1088894-2-andrii@kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/lib/bpf/libbpf.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
    index 51180f300d2e1..7145463a4a562 100644
    --- a/tools/lib/bpf/libbpf.c
    +++ b/tools/lib/bpf/libbpf.c
    @@ -5138,7 +5138,7 @@ static int bpf_core_apply_relo(struct bpf_program *prog,
    * relocated, so it's enough to just subtract in-section offset
    */
    insn_idx = insn_idx - prog->sec_insn_off;
    - if (insn_idx > prog->insns_cnt)
    + if (insn_idx >= prog->insns_cnt)
    return -EINVAL;
    insn = &prog->insns[insn_idx];

    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 01:10    [W:3.431 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site