lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 892/917] remoteproc: elf_loader: Fix loading segment when is_iomem true
    Date
    From: Peng Fan <peng.fan@nxp.com>

    commit 24acbd9dc934f5d9418a736c532d3970a272063e upstream.

    It seems luckliy work on i.MX platform, but it is wrong.
    Need use memcpy_toio, not memcpy_fromio.

    Fixes: 40df0a91b2a5 ("remoteproc: add is_iomem to da_to_va")
    Tested-by: Dong Aisheng <aisheng.dong@nxp.com> (i.MX8MQ)
    Reported-by: kernel test robot <lkp@intel.com>
    Reported-by: Dong Aisheng <aisheng.dong@nxp.com>
    Signed-off-by: Peng Fan <peng.fan@nxp.com>
    Cc: stable <stable@vger.kernel.org>
    Link: https://lore.kernel.org/r/20210910090621.3073540-2-peng.fan@oss.nxp.com
    Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
    Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/remoteproc/remoteproc_elf_loader.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/remoteproc/remoteproc_elf_loader.c
    +++ b/drivers/remoteproc/remoteproc_elf_loader.c
    @@ -220,7 +220,7 @@ int rproc_elf_load_segments(struct rproc
    /* put the segment where the remote processor expects it */
    if (filesz) {
    if (is_iomem)
    - memcpy_fromio(ptr, (void __iomem *)(elf_data + offset), filesz);
    + memcpy_toio((void __iomem *)ptr, elf_data + offset, filesz);
    else
    memcpy(ptr, elf_data + offset, filesz);
    }

    \
     
     \ /
      Last update: 2021-11-16 01:03    [W:2.384 / U:0.684 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site