lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 812/917] can: mcp251xfd: mcp251xfd_chip_start(): fix error handling for mcp251xfd_chip_rx_int_enable()
    Date
    From: Marc Kleine-Budde <mkl@pengutronix.de>

    [ Upstream commit 69c55f6e7669d46bb40e41f6e2b218428178368a ]

    This patch fixes the error handling for mcp251xfd_chip_rx_int_enable().
    Instead just returning the error, properly shut down the chip.

    Link: https://lore.kernel.org/all/20211106201526.44292-2-mkl@pengutronix.de
    Fixes: 55e5b97f003e ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN")
    Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
    index 212fcd1554e4f..e16dc482f3270 100644
    --- a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
    +++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
    @@ -1092,7 +1092,7 @@ static int mcp251xfd_chip_start(struct mcp251xfd_priv *priv)

    err = mcp251xfd_chip_rx_int_enable(priv);
    if (err)
    - return err;
    + goto out_chip_stop;

    err = mcp251xfd_chip_ecc_init(priv);
    if (err)
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 01:02    [W:3.097 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site