lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 838/917] net: stmmac: allow a tc-taprio base-time of zero
    Date
    From: Vladimir Oltean <vladimir.oltean@nxp.com>

    [ Upstream commit f64ab8e4f368f48afb08ae91928e103d17b235e9 ]

    Commit fe28c53ed71d ("net: stmmac: fix taprio configuration when
    base_time is in the past") allowed some base time values in the past,
    but apparently not all, the base-time value of 0 (Jan 1st 1970) is still
    explicitly denied by the driver.

    Remove the bogus check.

    Fixes: b60189e0392f ("net: stmmac: Integrate EST with TAPRIO scheduler API")
    Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
    Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c
    index 8160087ee92f2..1c4ea0b1b845b 100644
    --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c
    +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c
    @@ -786,8 +786,6 @@ static int tc_setup_taprio(struct stmmac_priv *priv,
    goto disable;
    if (qopt->num_entries >= dep)
    return -EINVAL;
    - if (!qopt->base_time)
    - return -ERANGE;
    if (!qopt->cycle_time)
    return -ERANGE;

    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 01:02    [W:2.288 / U:1.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site