lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 839/917] net: ethernet: ti: cpsw_ale: Fix access to un-initialized memory
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit 7a166854b4e24c57d56b3eba9fe1594985ee0a2c ]

    It is spurious to allocate a bitmap without initializing it.
    So, better safe than sorry, initialize it to 0 at least to have some known
    values.

    While at it, switch to the devm_bitmap_ API which is less verbose.

    Fixes: 4b41d3436796 ("net: ethernet: ti: cpsw: allow untagged traffic on host port")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/ti/cpsw_ale.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/net/ethernet/ti/cpsw_ale.c b/drivers/net/ethernet/ti/cpsw_ale.c
    index 0c75e0576ee1f..1ef0aaef5c61c 100644
    --- a/drivers/net/ethernet/ti/cpsw_ale.c
    +++ b/drivers/net/ethernet/ti/cpsw_ale.c
    @@ -1299,10 +1299,8 @@ struct cpsw_ale *cpsw_ale_create(struct cpsw_ale_params *params)
    if (!ale)
    return ERR_PTR(-ENOMEM);

    - ale->p0_untag_vid_mask =
    - devm_kmalloc_array(params->dev, BITS_TO_LONGS(VLAN_N_VID),
    - sizeof(unsigned long),
    - GFP_KERNEL);
    + ale->p0_untag_vid_mask = devm_bitmap_zalloc(params->dev, VLAN_N_VID,
    + GFP_KERNEL);
    if (!ale->p0_untag_vid_mask)
    return ERR_PTR(-ENOMEM);

    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 01:02    [W:3.335 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site