lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 657/917] firmware: qcom_scm: Fix error retval in __qcom_scm_is_call_available()
    Date
    From: Guru Das Srinagesh <quic_gurus@quicinc.com>

    [ Upstream commit 38212b2a8a6fc4c3a6fa99d7445b833bedc9a67c ]

    Since __qcom_scm_is_call_available() returns bool, have it return false
    instead of -EINVAL if an invalid SMC convention is detected.

    This fixes the Smatch static checker warning:

    drivers/firmware/qcom_scm.c:255 __qcom_scm_is_call_available()
    warn: signedness bug returning '(-22)'

    Fixes: 9d11af8b06a8 ("firmware: qcom_scm: Make __qcom_scm_is_call_available() return bool")
    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Guru Das Srinagesh <quic_gurus@quicinc.com>
    Reviewed-by: Stephen Boyd <swboyd@chromium.org>
    Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Link: https://lore.kernel.org/r/1633982414-28347-1-git-send-email-quic_gurus@quicinc.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/firmware/qcom_scm.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
    index 2ee97bab74409..27a64de919817 100644
    --- a/drivers/firmware/qcom_scm.c
    +++ b/drivers/firmware/qcom_scm.c
    @@ -252,7 +252,7 @@ static bool __qcom_scm_is_call_available(struct device *dev, u32 svc_id,
    break;
    default:
    pr_err("Unknown SMC convention being used\n");
    - return -EINVAL;
    + return false;
    }

    ret = qcom_scm_call(dev, &desc, &res);
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 00:59    [W:2.416 / U:0.264 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site