lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 646/917] usb: typec: STUSB160X should select REGMAP_I2C
    Date
    From: Randy Dunlap <rdunlap@infradead.org>

    [ Upstream commit 8ef1e58783b9f55daa4a865c7801dc75cbeb8260 ]

    REGMAP_I2C is not a user visible kconfig symbol so driver configs
    should not "depend on" it. They should depend on I2C and then
    select REGMAP_I2C.

    If this worked, it was only because some other driver had set/enabled
    REGMAP_I2C.

    Fixes: da0cb6310094 ("usb: typec: add support for STUSB160x Type-C controller family")
    Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
    Cc: Amelie Delaunay <amelie.delaunay@st.com>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: linux-usb@vger.kernel.org
    Reviewed-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
    Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
    Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    Link: https://lore.kernel.org/r/20211015013609.7300-1-rdunlap@infradead.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/typec/Kconfig | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig
    index a0418f23b4aae..ab480f38523aa 100644
    --- a/drivers/usb/typec/Kconfig
    +++ b/drivers/usb/typec/Kconfig
    @@ -65,9 +65,9 @@ config TYPEC_HD3SS3220

    config TYPEC_STUSB160X
    tristate "STMicroelectronics STUSB160x Type-C controller driver"
    - depends on I2C
    - depends on REGMAP_I2C
    depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH
    + depends on I2C
    + select REGMAP_I2C
    help
    Say Y or M here if your system has STMicroelectronics STUSB160x
    Type-C port controller.
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 00:59    [W:2.173 / U:1.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site