lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 647/917] iio: adis: do not disabe IRQs in adis_init()
    Date
    From: Nuno Sá <nuno.sa@analog.com>

    [ Upstream commit b600bd7eb333554518b4dd36b882b2ae58a5149e ]

    With commit ecb010d441088 ("iio: imu: adis: Refactor adis_initial_startup")
    we are doing a HW or SW reset to the device which means that we'll get
    the default state of the data ready pin (which is enabled). Hence there's
    no point in disabling the IRQ in the init function. Moreover, this
    function is intended to initialize internal data structures and not
    really do anything on the device.

    As a result of this, some devices were left with the data ready pin enabled
    after probe which was not the desired behavior. Thus, we move the call to
    'adis_enable_irq()' to the initial startup function where it makes more
    sense for it to be.

    Note that for devices that cannot mask/unmask the pin, it makes no sense
    to call the function at this point since the IRQ should not have been
    yet requested. This will be improved in a follow up change.

    Fixes: ecb010d441088 ("iio: imu: adis: Refactor adis_initial_startup")
    Signed-off-by: Nuno Sá <nuno.sa@analog.com>
    Link: https://lore.kernel.org/r/20210903141423.517028-2-nuno.sa@analog.com
    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/iio/imu/adis.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c
    index b9a06ca29beec..d4e692b187cda 100644
    --- a/drivers/iio/imu/adis.c
    +++ b/drivers/iio/imu/adis.c
    @@ -430,6 +430,8 @@ int __adis_initial_startup(struct adis *adis)
    if (ret)
    return ret;

    + adis_enable_irq(adis, false);
    +
    if (!adis->data->prod_id_reg)
    return 0;

    @@ -526,7 +528,7 @@ int adis_init(struct adis *adis, struct iio_dev *indio_dev,
    adis->current_page = 0;
    }

    - return adis_enable_irq(adis, false);
    + return 0;
    }
    EXPORT_SYMBOL_GPL(adis_init);

    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 00:59    [W:3.741 / U:0.404 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site