lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 604/917] ALSA: hda: Use position buffer for SKL+ again
    Date
    From: Takashi Iwai <tiwai@suse.de>

    [ Upstream commit c4ca3871e21fa085096316f5f8d9975cf3dfde1d ]

    The commit f87e7f25893d ("ALSA: hda - Improved position reporting on
    SKL+") changed the PCM position report for SKL+ chips to use DPIB, but
    according to Pierre, DPIB is no best choice for the accurate position
    reports and it often reports too early. The recommended method is
    rather the classical position buffer.

    This patch makes the PCM position reporting on SKL+ back to the
    position buffer again.

    Fixes: f87e7f25893d ("ALSA: hda - Improved position reporting on SKL+")
    Suggested-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    Link: https://lore.kernel.org/r/20210929072934.6809-3-tiwai@suse.de
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/pci/hda/hda_intel.c | 23 +----------------------
    1 file changed, 1 insertion(+), 22 deletions(-)

    diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
    index 95b9a615c47ca..90e9263ac0bd7 100644
    --- a/sound/pci/hda/hda_intel.c
    +++ b/sound/pci/hda/hda_intel.c
    @@ -881,27 +881,6 @@ static int azx_get_delay_from_fifo(struct azx *chip, struct azx_dev *azx_dev,
    return substream->runtime->delay;
    }

    -static unsigned int azx_skl_get_dpib_pos(struct azx *chip,
    - struct azx_dev *azx_dev)
    -{
    - return _snd_hdac_chip_readl(azx_bus(chip),
    - AZX_REG_VS_SDXDPIB_XBASE +
    - (AZX_REG_VS_SDXDPIB_XINTERVAL *
    - azx_dev->core.index));
    -}
    -
    -/* get the current DMA position with correction on SKL+ chips */
    -static unsigned int azx_get_pos_skl(struct azx *chip, struct azx_dev *azx_dev)
    -{
    - /* DPIB register gives a more accurate position for playback */
    - if (azx_dev->core.substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
    - return azx_skl_get_dpib_pos(chip, azx_dev);
    -
    - /* read of DPIB fetches the actual posbuf */
    - azx_skl_get_dpib_pos(chip, azx_dev);
    - return azx_get_pos_posbuf(chip, azx_dev);
    -}
    -
    static void __azx_shutdown_chip(struct azx *chip, bool skip_link_reset)
    {
    azx_stop_chip(chip);
    @@ -1591,7 +1570,7 @@ static void assign_position_fix(struct azx *chip, int fix)
    [POS_FIX_POSBUF] = azx_get_pos_posbuf,
    [POS_FIX_VIACOMBO] = azx_via_get_position,
    [POS_FIX_COMBO] = azx_get_pos_lpib,
    - [POS_FIX_SKL] = azx_get_pos_skl,
    + [POS_FIX_SKL] = azx_get_pos_posbuf,
    [POS_FIX_FIFO] = azx_get_pos_fifo,
    };

    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 00:52    [W:2.359 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site