lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 541/917] selftests/bpf: Fix memory leak in test_ima
    Date
    From: Kumar Kartikeya Dwivedi <memxor@gmail.com>

    [ Upstream commit efadf2ad17a2d5dc90bda4e6e8b2f96af4c62dae ]

    The allocated ring buffer is never freed, do so in the cleanup path.

    Fixes: f446b570ac7e ("bpf/selftests: Update the IMA test to use BPF ring buffer")
    Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
    Signed-off-by: Alexei Starovoitov <ast@kernel.org>
    Acked-by: Andrii Nakryiko <andrii@kernel.org>
    Acked-by: Song Liu <songliubraving@fb.com>
    Link: https://lore.kernel.org/bpf/20211028063501.2239335-9-memxor@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/testing/selftests/bpf/prog_tests/test_ima.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/tools/testing/selftests/bpf/prog_tests/test_ima.c b/tools/testing/selftests/bpf/prog_tests/test_ima.c
    index 0252f61d611a9..97d8a6f84f4ab 100644
    --- a/tools/testing/selftests/bpf/prog_tests/test_ima.c
    +++ b/tools/testing/selftests/bpf/prog_tests/test_ima.c
    @@ -43,7 +43,7 @@ static int process_sample(void *ctx, void *data, size_t len)
    void test_test_ima(void)
    {
    char measured_dir_template[] = "/tmp/ima_measuredXXXXXX";
    - struct ring_buffer *ringbuf;
    + struct ring_buffer *ringbuf = NULL;
    const char *measured_dir;
    char cmd[256];

    @@ -85,5 +85,6 @@ close_clean:
    err = system(cmd);
    CHECK(err, "failed to run command", "%s, errno = %d\n", cmd, errno);
    close_prog:
    + ring_buffer__free(ringbuf);
    ima__destroy(skel);
    }
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 00:45    [W:3.123 / U:0.356 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site