lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 456/917] drm/amdkfd: Fix an inappropriate error handling in allloc memory of gpu
    Date
    From: Lang Yu <lang.yu@amd.com>

    [ Upstream commit 5aeeac6fa38fca450faed9770f75b1470c0e2073 ]

    We should unreference a gem object instead of an amdgpu bo here.

    Fixes: fd9a9f8801de ("drm/amdgpu: Use GEM obj reference for KFD BOs")

    Signed-off-by: Lang Yu <lang.yu@amd.com>
    Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
    index 054c1a224defb..cdf46bd0d8d5b 100644
    --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
    +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
    @@ -1503,7 +1503,7 @@ allocate_init_user_pages_failed:
    remove_kgd_mem_from_kfd_bo_list(*mem, avm->process_info);
    drm_vma_node_revoke(&gobj->vma_node, drm_priv);
    err_node_allow:
    - amdgpu_bo_unref(&bo);
    + drm_gem_object_put(gobj);
    /* Don't unreserve system mem limit twice */
    goto err_reserve_limit;
    err_bo_create:
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 00:43    [W:4.025 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site