lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 327/917] drm/bridge: it66121: Initialize {device,vendor}_ids
    Date
    From: Paul Cercueil <paul@crapouillou.net>

    [ Upstream commit 3a5f3d61de657bc1c2b53b77d065c5526f982e10 ]

    These two arrays are populated with data read from the I2C device
    through regmap_read(), and the data is then compared with hardcoded
    vendor/product ID values of supported chips.

    However, the return value of regmap_read() was never checked. This is
    fine, as long as the two arrays are zero-initialized, so that we don't
    compare the vendor/product IDs against whatever garbage is left on the
    stack.

    Address this issue by zero-initializing these two arrays.

    Signed-off-by: Paul Cercueil <paul@crapouillou.net>
    Fixes: 988156dc2fc9 ("drm: bridge: add it66121 driver")
    Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
    Signed-off-by: Robert Foss <robert.foss@linaro.org>
    Link: https://patchwork.freedesktop.org/patch/msgid/20210827163956.27517-1-paul@crapouillou.net
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/bridge/ite-it66121.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
    index 2f2a09adb4bc8..b130d01147c6c 100644
    --- a/drivers/gpu/drm/bridge/ite-it66121.c
    +++ b/drivers/gpu/drm/bridge/ite-it66121.c
    @@ -889,7 +889,7 @@ unlock:
    static int it66121_probe(struct i2c_client *client,
    const struct i2c_device_id *id)
    {
    - u32 vendor_ids[2], device_ids[2], revision_id;
    + u32 revision_id, vendor_ids[2] = { 0 }, device_ids[2] = { 0 };
    struct device_node *ep;
    int ret;
    struct it66121_ctx *ctx;
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 00:40    [W:4.017 / U:0.264 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site