lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 091/917] wcn36xx: Fix (QoS) null data frame bitrate/modulation
    Date
    From: Loic Poulain <loic.poulain@linaro.org>

    commit d3fd2c95c1c13ec217d43ebef3c61cfa00a6cd37 upstream.

    We observe unexpected connection drops with some APs due to
    non-acked mac80211 generated null data frames (keep-alive).
    After debugging and capture, we noticed that null frames are
    submitted at standard data bitrate and that the given APs are
    in trouble with that.

    After setting the null frame bitrate to control bitrate, all
    null frames are acked as expected and connection is maintained.

    Not sure if it's a requirement of the specification, but it seems
    the right thing to do anyway, null frames are mostly used for control
    purpose (power-saving, keep-alive...), and submitting them with
    a slower/simpler bitrate/modulation is more robust.

    Cc: stable@vger.kernel.org
    Fixes: 512b191d9652 ("wcn36xx: Fix TX data path")
    Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    Link: https://lore.kernel.org/r/1634560399-15290-1-git-send-email-loic.poulain@linaro.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/wireless/ath/wcn36xx/txrx.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/net/wireless/ath/wcn36xx/txrx.c
    +++ b/drivers/net/wireless/ath/wcn36xx/txrx.c
    @@ -429,6 +429,7 @@ static void wcn36xx_set_tx_data(struct w
    if (ieee80211_is_any_nullfunc(hdr->frame_control)) {
    /* Don't use a regular queue for null packet (no ampdu) */
    bd->queue_id = WCN36XX_TX_U_WQ_ID;
    + bd->bd_rate = WCN36XX_BD_RATE_CTRL;
    }

    if (bcast) {

    \
     
     \ /
      Last update: 2021-11-16 00:32    [W:4.018 / U:0.504 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site