lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 064/917] KVM: x86/mmu: Drop a redundant, broken remote TLB flush
    Date
    From: Sean Christopherson <seanjc@google.com>

    commit bc3b3c1002ea684e618ff6d8c387b1b8b319f140 upstream.

    A recent commit to fix the calls to kvm_flush_remote_tlbs_with_address()
    in kvm_zap_gfn_range() inadvertantly added yet another flush instead of
    fixing the existing flush. Drop the redundant flush, and fix the params
    for the existing flush.

    Cc: stable@vger.kernel.org
    Fixes: 2822da446640 ("KVM: x86/mmu: fix parameters to kvm_flush_remote_tlbs_with_address")
    Cc: Maxim Levitsky <mlevitsk@redhat.com>
    Cc: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
    Signed-off-by: Sean Christopherson <seanjc@google.com>
    Message-Id: <20211022010005.1454978-2-seanjc@google.com>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    arch/x86/kvm/mmu/mmu.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    --- a/arch/x86/kvm/mmu/mmu.c
    +++ b/arch/x86/kvm/mmu/mmu.c
    @@ -5758,13 +5758,11 @@ void kvm_zap_gfn_range(struct kvm *kvm,
    for (i = 0; i < KVM_ADDRESS_SPACE_NUM; i++)
    flush = kvm_tdp_mmu_zap_gfn_range(kvm, i, gfn_start,
    gfn_end, flush);
    - if (flush)
    - kvm_flush_remote_tlbs_with_address(kvm, gfn_start,
    - gfn_end - gfn_start);
    }

    if (flush)
    - kvm_flush_remote_tlbs_with_address(kvm, gfn_start, gfn_end);
    + kvm_flush_remote_tlbs_with_address(kvm, gfn_start,
    + gfn_end - gfn_start);

    kvm_dec_notifier_count(kvm, gfn_start, gfn_end);


    \
     
     \ /
      Last update: 2021-11-16 00:29    [W:2.678 / U:0.360 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site