lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 04/12] ubifs: Add missing iput if do_tmpfile() failed in rename whiteout
From
Date
在 2021/11/15 16:24, Sascha Hauer 写道:
Hi Sascha,
>> diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
>> index 2735ad1affed..6503e6857f6e 100644
>> --- a/fs/ubifs/dir.c
>> +++ b/fs/ubifs/dir.c
>> @@ -1334,6 +1334,8 @@ static int do_rename(struct inode *old_dir, struct dentry *old_dentry,
>>
>> err = do_tmpfile(old_dir, old_dentry, S_IFCHR | WHITEOUT_MODE, &whiteout);
>> if (err) {
>> + if (whiteout)
>> + iput(whiteout);
>
> Should this rather be done in do_tmpfile() directly?
Yes, I should have done it. Although next patch reconstructs do_rename()
which makes this ugly judgement disappered. I will fix it along with
other suggestions from other patches in next iteration. Thanks.
> Sascha
>

\
 
 \ /
  Last update: 2021-11-15 10:22    [W:0.092 / U:0.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site