lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 729/849] PCI: j721e: Fix j721e_pcie_probe() error path
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit 496bb18483cc0474913e81e18a6b313aaea4c120 ]

    If an error occurs after a successful cdns_pcie_init_phy() call, it must be
    undone by a cdns_pcie_disable_phy() call, as already done above and below.

    Update the goto to branch at the correct place of the error handling path.

    Link: https://lore.kernel.org/r/db477b0cb444891a17c4bb424467667dc30d0bab.1624794264.git.christophe.jaillet@wanadoo.fr
    Fixes: 49e0efdce791 ("PCI: j721e: Add support to provide refclk to PCIe connector")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
    Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pci/controller/cadence/pci-j721e.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c
    index ffb176d288cd9..918e11082e6a7 100644
    --- a/drivers/pci/controller/cadence/pci-j721e.c
    +++ b/drivers/pci/controller/cadence/pci-j721e.c
    @@ -474,7 +474,7 @@ static int j721e_pcie_probe(struct platform_device *pdev)
    ret = clk_prepare_enable(clk);
    if (ret) {
    dev_err(dev, "failed to enable pcie_refclk\n");
    - goto err_get_sync;
    + goto err_pcie_setup;
    }
    pcie->refclk = clk;

    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 00:19    [W:2.857 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site