lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 515/849] spi: spi-rpc-if: Check return value of rpcif_sw_init()
    Date
    From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

    [ Upstream commit 0b0a281ed7001d4c4f4c47bdc84680c4997761ca ]

    rpcif_sw_init() can fail so make sure we check the return value
    of it and on error exit rpcif_spi_probe() callback with error code.

    Fixes: eb8d6d464a27 ("spi: add Renesas RPC-IF driver")
    Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
    Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
    Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
    Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Link: https://lore.kernel.org/r/20211025205631.21151-4-prabhakar.mahadev-lad.rj@bp.renesas.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/spi/spi-rpc-if.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/spi/spi-rpc-if.c b/drivers/spi/spi-rpc-if.c
    index c53138ce00309..83796a4ead34a 100644
    --- a/drivers/spi/spi-rpc-if.c
    +++ b/drivers/spi/spi-rpc-if.c
    @@ -139,7 +139,9 @@ static int rpcif_spi_probe(struct platform_device *pdev)
    return -ENOMEM;

    rpc = spi_controller_get_devdata(ctlr);
    - rpcif_sw_init(rpc, parent);
    + error = rpcif_sw_init(rpc, parent);
    + if (error)
    + return error;

    platform_set_drvdata(pdev, ctlr);

    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 00:10    [W:2.739 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site