lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 511/849] tpm_tis_spi: Add missing SPI ID
    Date
    From: Mark Brown <broonie@kernel.org>

    [ Upstream commit 7eba41fe8c7bb01ff3d4b757bd622375792bc720 ]

    In commit c46ed2281bbe ("tpm_tis_spi: add missing SPI device ID entries")
    we added SPI IDs for all the DT aliases to handle the fact that we always
    use SPI modaliases to load modules even when probed via DT however the
    mentioned commit missed that the SPI and OF device ID entries did not
    match and were different and so DT nodes with compatible
    "tcg,tpm_tis-spi" will not match. Add an extra ID for tpm_tis-spi
    rather than just fix the existing one since what's currently there is
    going to be better for anyone actually using SPI IDs to instantiate.

    Fixes: c46ed2281bbe ("tpm_tis_spi: add missing SPI device ID entries")
    Fixes: 96c8395e2166 ("spi: Revert modalias changes")
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
    Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
    Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/char/tpm/tpm_tis_spi_main.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/char/tpm/tpm_tis_spi_main.c b/drivers/char/tpm/tpm_tis_spi_main.c
    index 54584b4b00d19..aaa59a00eeaef 100644
    --- a/drivers/char/tpm/tpm_tis_spi_main.c
    +++ b/drivers/char/tpm/tpm_tis_spi_main.c
    @@ -267,6 +267,7 @@ static const struct spi_device_id tpm_tis_spi_id[] = {
    { "st33htpm-spi", (unsigned long)tpm_tis_spi_probe },
    { "slb9670", (unsigned long)tpm_tis_spi_probe },
    { "tpm_tis_spi", (unsigned long)tpm_tis_spi_probe },
    + { "tpm_tis-spi", (unsigned long)tpm_tis_spi_probe },
    { "cr50", (unsigned long)cr50_spi_probe },
    {}
    };
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 00:04    [W:4.082 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site