lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 471/849] mt76: mt7921: fix retrying release semaphore without end
    Date
    From: Sean Wang <sean.wang@mediatek.com>

    [ Upstream commit 02d1c7d494d8052288bc175e4ff54b56d08a3c5f ]

    We should pass the error code to the caller immediately
    to avoid the possible infinite retry to release the semaphore.

    Fixes: 1c099ab44727 ("mt76: mt7921: add MCU support")
    Co-developed-by: YN Chen <YN.Chen@mediatek.com>
    Signed-off-by: YN Chen <YN.Chen@mediatek.com>
    Signed-off-by: Sean Wang <sean.wang@mediatek.com>
    Signed-off-by: Felix Fietkau <nbd@nbd.name>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/mediatek/mt76/mt7921/mcu.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
    index 3cb53c642d242..506a1909ce6d5 100644
    --- a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
    +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
    @@ -827,7 +827,7 @@ out:
    default:
    ret = -EAGAIN;
    dev_err(dev->mt76.dev, "Failed to release patch semaphore\n");
    - goto out;
    + break;
    }
    release_firmware(fw);

    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 00:03    [W:4.023 / U:0.332 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site