lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 438/849] drm/msm: uninitialized variable in msm_gem_import()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 2203bd0e5c12ffc53ffdd4fbd7b12d6ba27e0424 ]

    The msm_gem_new_impl() function cleans up after itself so there is no
    need to call drm_gem_object_put(). Conceptually, it does not make sense
    to call a kref_put() function until after the reference counting has
    been initialized which happens immediately after this call in the
    drm_gem_(private_)object_init() functions.

    In the msm_gem_import() function the "obj" pointer is uninitialized, so
    it will lead to a crash.

    Fixes: 05b849111c07 ("drm/msm: prime support")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Link: https://lore.kernel.org/r/20211013081315.GG6010@kili
    Signed-off-by: Rob Clark <robdclark@chromium.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/msm/msm_gem.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
    index 1ba18f53dbda1..9533225b5c88c 100644
    --- a/drivers/gpu/drm/msm/msm_gem.c
    +++ b/drivers/gpu/drm/msm/msm_gem.c
    @@ -1220,7 +1220,7 @@ static struct drm_gem_object *_msm_gem_new(struct drm_device *dev,

    ret = msm_gem_new_impl(dev, size, flags, &obj);
    if (ret)
    - goto fail;
    + return ERR_PTR(ret);

    msm_obj = to_msm_bo(obj);

    @@ -1320,7 +1320,7 @@ struct drm_gem_object *msm_gem_import(struct drm_device *dev,

    ret = msm_gem_new_impl(dev, size, MSM_BO_WC, &obj);
    if (ret)
    - goto fail;
    + return ERR_PTR(ret);

    drm_gem_private_object_init(dev, obj, size);

    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 00:03    [W:4.032 / U:1.996 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site