lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 440/849] mailbox: Remove WARN_ON for async_cb.cb in cmdq_exec_done
    Date
    From: jason-jh.lin <jason-jh.lin@mediatek.com>

    [ Upstream commit ce1537fe288469bf68ee0aabdb860a790b4755ef ]

    Because mtk_drm_crtc_update_config is not using cmdq_pkt_flush_async,
    it won't have pkt->async_cb.cb anymore.

    So remove the WARN_ON check of pkt->async_cb.cb at cmdq_exec_done.

    Fixes: 1b6b0ce2240e ("mailbox: mtk-cmdq: Use mailbox rx_callback")
    Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com>
    Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
    Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
    Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mailbox/mtk-cmdq-mailbox.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
    index 4f907e8f3894b..5e2796db026d2 100644
    --- a/drivers/mailbox/mtk-cmdq-mailbox.c
    +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
    @@ -186,7 +186,6 @@ static void cmdq_task_exec_done(struct cmdq_task *task, int sta)
    struct cmdq_task_cb *cb = &task->pkt->async_cb;
    struct cmdq_cb_data data;

    - WARN_ON(cb->cb == (cmdq_async_flush_cb)NULL);
    data.sta = sta;
    data.data = cb->data;
    data.pkt = task->pkt;
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-16 00:03    [W:4.025 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site