lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 436/849] drm/msm: potential error pointer dereference in init()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit b6816441a14bbe356ba8590de79cfea2de6a085c ]

    The msm_iommu_new() returns error pointers on failure so check for that
    to avoid an Oops.

    Fixes: ccac7ce373c1 ("drm/msm: Refactor address space initialization")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
    Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
    Link: https://lore.kernel.org/r/20211004103806.GD25015@kili
    Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
    Signed-off-by: Rob Clark <robdclark@chromium.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
    index 4fd913522931b..5489a3ae2bedb 100644
    --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
    +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
    @@ -896,6 +896,10 @@ static int _dpu_kms_mmu_init(struct dpu_kms *dpu_kms)
    return 0;

    mmu = msm_iommu_new(dpu_kms->dev->dev, domain);
    + if (IS_ERR(mmu)) {
    + iommu_domain_free(domain);
    + return PTR_ERR(mmu);
    + }
    aspace = msm_gem_address_space_create(mmu, "dpu1",
    0x1000, 0x100000000 - 0x1000);

    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-15 23:59    [W:3.119 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site