lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 380/849] media: cxd2880-spi: Fix a null pointer dereference on error handling path
    Date
    From: Colin Ian King <colin.king@canonical.com>

    [ Upstream commit 11b982e950d2138e90bd120501df10a439006ff8 ]

    Currently the null pointer check on dvb_spi->vcc_supply is inverted and
    this leads to only null values of the dvb_spi->vcc_supply being passed
    to the call of regulator_disable causing null pointer dereferences.
    Fix this by only calling regulator_disable if dvb_spi->vcc_supply is
    not null.

    Addresses-Coverity: ("Dereference after null check")

    Fixes: dcb014582101 ("media: cxd2880-spi: Fix an error handling path")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: Sean Young <sean@mess.org>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/spi/cxd2880-spi.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/spi/cxd2880-spi.c b/drivers/media/spi/cxd2880-spi.c
    index b91a1e845b972..506f52c1af101 100644
    --- a/drivers/media/spi/cxd2880-spi.c
    +++ b/drivers/media/spi/cxd2880-spi.c
    @@ -618,7 +618,7 @@ fail_frontend:
    fail_attach:
    dvb_unregister_adapter(&dvb_spi->adapter);
    fail_adapter:
    - if (!dvb_spi->vcc_supply)
    + if (dvb_spi->vcc_supply)
    regulator_disable(dvb_spi->vcc_supply);
    fail_regulator:
    kfree(dvb_spi);
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-15 23:56    [W:4.062 / U:0.460 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site