lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 277/849] net: phy: micrel: make *-skew-ps check more lenient
    Date
    From: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>

    [ Upstream commit 67ca5159dbe2edb5dae7544447b8677d2596933a ]

    It seems reasonable to fine-tune only some of the skew values when using
    one of the rgmii-*id PHY modes, and even when all skew values are
    specified, using the correct ID PHY mode makes sense for documentation
    purposes. Such a configuration also appears in the binding docs in
    Documentation/devicetree/bindings/net/micrel-ksz90x1.txt, so the driver
    should not warn about it.

    Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
    Link: https://lore.kernel.org/r/20211012103402.21438-1-matthias.schiffer@ew.tq-group.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/phy/micrel.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
    index 5c928f827173c..643b1c1827a92 100644
    --- a/drivers/net/phy/micrel.c
    +++ b/drivers/net/phy/micrel.c
    @@ -863,9 +863,9 @@ static int ksz9031_config_init(struct phy_device *phydev)
    MII_KSZ9031RN_TX_DATA_PAD_SKEW, 4,
    tx_data_skews, 4, &update);

    - if (update && phydev->interface != PHY_INTERFACE_MODE_RGMII)
    + if (update && !phy_interface_is_rgmii(phydev))
    phydev_warn(phydev,
    - "*-skew-ps values should be used only with phy-mode = \"rgmii\"\n");
    + "*-skew-ps values should be used only with RGMII PHY modes\n");

    /* Silicon Errata Sheet (DS80000691D or DS80000692D):
    * When the device links in the 1000BASE-T slave mode only,
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-15 23:31    [W:4.150 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site