lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 089/849] nvmet-tcp: fix header digest verification
    Date
    From: Amit Engel <amit.engel@dell.com>

    [ Upstream commit 86aeda32b887cdaeb0f4b7bfc9971e36377181c7 ]

    Pass the correct length to nvmet_tcp_verify_hdgst, which is the pdu
    header length. This fixes a wrong behaviour where header digest
    verification passes although the digest is wrong.

    Signed-off-by: Amit Engel <amit.engel@dell.com>
    Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
    Signed-off-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/nvme/target/tcp.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c
    index 586ca20837e7b..46c3b3be7e033 100644
    --- a/drivers/nvme/target/tcp.c
    +++ b/drivers/nvme/target/tcp.c
    @@ -1096,7 +1096,7 @@ recv:
    }

    if (queue->hdr_digest &&
    - nvmet_tcp_verify_hdgst(queue, &queue->pdu, queue->offset)) {
    + nvmet_tcp_verify_hdgst(queue, &queue->pdu, hdr->hlen)) {
    nvmet_tcp_fatal_error(queue); /* fatal */
    return -EPROTO;
    }
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-15 22:39    [W:3.127 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site