lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 557/575] video: backlight: Drop maximum brightness override for brightness zero
    Date
    From: Marek Vasut <marex@denx.de>

    commit 33a5471f8da976bf271a1ebbd6b9d163cb0cb6aa upstream.

    The note in c2adda27d202f ("video: backlight: Add of_find_backlight helper
    in backlight.c") says that gpio-backlight uses brightness as power state.
    This has been fixed since in ec665b756e6f7 ("backlight: gpio-backlight:
    Correct initial power state handling") and other backlight drivers do not
    require this workaround. Drop the workaround.

    This fixes the case where e.g. pwm-backlight can perfectly well be set to
    brightness 0 on boot in DT, which without this patch leads to the display
    brightness to be max instead of off.

    Fixes: c2adda27d202f ("video: backlight: Add of_find_backlight helper in backlight.c")
    Cc: <stable@vger.kernel.org> # 5.4+
    Cc: <stable@vger.kernel.org> # 4.19.x: ec665b756e6f7: backlight: gpio-backlight: Correct initial power state handling
    Signed-off-by: Marek Vasut <marex@denx.de>
    Acked-by: Noralf Trønnes <noralf@tronnes.org>
    Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/video/backlight/backlight.c | 6 ------
    1 file changed, 6 deletions(-)

    --- a/drivers/video/backlight/backlight.c
    +++ b/drivers/video/backlight/backlight.c
    @@ -688,12 +688,6 @@ static struct backlight_device *of_find_
    of_node_put(np);
    if (!bd)
    return ERR_PTR(-EPROBE_DEFER);
    - /*
    - * Note: gpio_backlight uses brightness as
    - * power state during probe
    - */
    - if (!bd->props.brightness)
    - bd->props.brightness = bd->props.max_brightness;
    }
    }


    \
     
     \ /
      Last update: 2021-11-15 22:14    [W:3.933 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site