lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 248/575] btrfs: reflink: initialize return value to 0 in btrfs_extent_same()
    Date
    From: Sidong Yang <realwakka@gmail.com>

    [ Upstream commit 44bee215f72f13874c0e734a0712c2e3264c0108 ]

    Fix a warning reported by smatch that ret could be returned without
    initialized. The dedupe operations are supposed to to return 0 for a 0
    length range but the caller does not pass olen == 0. To keep this
    behaviour and also fix the warning initialize ret to 0.

    Reviewed-by: Filipe Manana <fdmanana@suse.com>
    Signed-off-by: Sidong Yang <realwakka@gmail.com>
    Reviewed-by: David Sterba <dsterba@suse.com>
    Signed-off-by: David Sterba <dsterba@suse.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/btrfs/reflink.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/btrfs/reflink.c b/fs/btrfs/reflink.c
    index 96ef9fed9a656..3a3102bc15a05 100644
    --- a/fs/btrfs/reflink.c
    +++ b/fs/btrfs/reflink.c
    @@ -634,7 +634,7 @@ static int btrfs_extent_same_range(struct inode *src, u64 loff, u64 len,
    static int btrfs_extent_same(struct inode *src, u64 loff, u64 olen,
    struct inode *dst, u64 dst_loff)
    {
    - int ret;
    + int ret = 0;
    u64 i, tail_len, chunk_count;
    struct btrfs_root *root_dst = BTRFS_I(dst)->root;

    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-15 20:53    [W:4.471 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site