Messages in this thread | | | Date | Mon, 15 Nov 2021 11:15:07 +0300 | Subject | Re: [PATCH v2] can: etas_es58x: fix error handling | From | Pavel Skripkin <> |
| |
On 11/15/21 11:11, Johan Hovold wrote: > Just a drive-by comment: > > Are you sure about this move of the netdev[channel_idx] initialisation? > What happens if the registered can device is opened before you > initialise the pointer? NULL-deref in es58x_send_msg()? > > You generally want the driver data fully initialised before you register > the device so this looks broken. > > And either way it is arguably an unrelated change that should go in a > separate patch explaining why it is needed and safe. >
It was suggested by Vincent who is the maintainer of this driver [1].
[1] https://lore.kernel.org/linux-can/CAMZ6Rq+orfUuUCCgeWyGc7P0vp3t-yjf_g9H=Jhk43f1zXGfDQ@mail.gmail.com/
With regards, Pavel Skripkin
| |