lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 080/575] net/smc: Fix smc_link->llc_testlink_time overflow
    Date
    From: Tony Lu <tonylu@linux.alibaba.com>

    [ Upstream commit c4a146c7cf5e8ad76231523b174d161bf152c6e7 ]

    The value of llc_testlink_time is set to the value stored in
    net->ipv4.sysctl_tcp_keepalive_time when linkgroup init. The value of
    sysctl_tcp_keepalive_time is already jiffies, so we don't need to
    multiply by HZ, which would cause smc_link->llc_testlink_time overflow,
    and test_link send flood.

    Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
    Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
    Reviewed-by: Wen Gu <guwen@linux.alibaba.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/smc/smc_llc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/smc/smc_llc.c b/net/smc/smc_llc.c
    index 2e7560eba9812..d8fe4e1f24d1f 100644
    --- a/net/smc/smc_llc.c
    +++ b/net/smc/smc_llc.c
    @@ -1787,7 +1787,7 @@ void smc_llc_link_active(struct smc_link *link)
    link->smcibdev->ibdev->name, link->ibport);
    link->state = SMC_LNK_ACTIVE;
    if (link->lgr->llc_testlink_time) {
    - link->llc_testlink_time = link->lgr->llc_testlink_time * HZ;
    + link->llc_testlink_time = link->lgr->llc_testlink_time;
    schedule_delayed_work(&link->llc_testlink_wrk,
    link->llc_testlink_time);
    }
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-15 20:40    [W:4.045 / U:0.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site