lkml.org 
[lkml]   [2021]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v6 3/5] EDAC/amd64: Extend family ops functions
    On Fri, Nov 12, 2021 at 08:59:21PM +0000, Yazen Ghannam wrote:
    > I've seen the same warning in some of my patches, but I've ignored it for
    > readability. I'll need to make changes there too. :/

    If readability is of concern, you can fixup the issues you see in a
    pre-patch - I mean, you're touching the code so might as well fix them
    while at it.

    What I really don't want to have is patches which simply fix random
    checkpatch issues and other whitespace crap because that becomes an
    insane mess with new people not really concentrating on fixing actual
    bugs but doing whitespace wankery only.

    And having such patches always gets in the way when one does git
    archeology to figure out why something was done the way it is.

    But it's fine to fix those if you're going to touch the code anyway.

    HTH.

    --
    Regards/Gruss,
    Boris.

    https://people.kernel.org/tglx/notes-about-netiquette

    \
     
     \ /
      Last update: 2021-11-13 12:58    [W:4.610 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site