Messages in this thread | | | Date | Sat, 13 Nov 2021 12:19:35 +0100 | From | "Sven Peter" <> | Subject | Re: [PATCH 2/2] watchdog: Add Apple SoC watchdog driver |
| |
Hi Janne,
On Sat, Nov 13, 2021, at 12:14, Janne Grunau wrote: > On 2021-11-13 10:47:32 +0100, Sven Peter wrote: >> Add support for the watchdog timer found in Apple SoCs. This driver is >> also required to reboot these machines. > > Tested on a M1 Max with > compatibe = "apple,t6000-wdt", "apple,wdt"; > MacOS 12 on the same machine does not use the watchdog for reset. MacOS > log output suggests that it uses a "pgmr" call for reset. > > Feel free to add > Tested-by: Janne Grunau <j@jannau.net>
Awesome, thanks for testing this! I suspect that they added an additional reset path for the Pro/Max variants. On my M1 macOS seems to only use this watchdog to reset the machine.
And if I understand the linux reset infrastructure correctly it's still fine to have this as a "fallback" reset notifier even on the Pro/Max and add support for the proper "pmgr" reset notifier eventually with a higher priority.
Best,
Sven
| |