lkml.org 
[lkml]   [2021]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] tipc: check for null after calling kmemdup
From
On 11/12/21 20:13, Jakub Kicinski wrote:
>>> @@ -597,6 +597,11 @@ static int tipc_aead_init(struct tipc_aead **aead, struct tipc_aead_key *ukey,
>>> tmp->cloned = NULL;
>>> tmp->authsize = TIPC_AES_GCM_TAG_SIZE;
>>> tmp->key = kmemdup(ukey, tipc_aead_key_size(ukey), GFP_KERNEL);
>>> + if (!tmp->key) {
>>> + free_percpu(tmp->tfm_entry);
>>> + kfree_sensitive(tmp);
>>> + return -ENOMEM;
>>> + }
>> Acked-by: Jon Maloy<jmaloy@redhat.com>
> Hm, shouldn't we free all the tfm entries here?

Right, I think we just need to call tipc_aead_free(&tmp->rcu);
here and return an error.

--
Thanks,
Tadeusz

\
 
 \ /
  Last update: 2021-11-13 06:43    [W:0.086 / U:0.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site