lkml.org 
[lkml]   [2021]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] staging: vt6655: fix camelcase byData in card.c
On Sat, Nov 06, 2021 at 12:06:30PM -0700, Joe Perches wrote:
> On Sat, 2021-11-06 at 19:48 +0100, Tommaso Merciai wrote:
> > Replace camelcase variable "byData" into linux kernel coding style
> > equivalent variable "data" in card.c.
> > "by" prefix in hungarian notation stands for byte or unsigned char
> []
> > diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> []
> > @@ -194,15 +194,15 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type)
> > priv->abyBBVGA[0] = 0x20;
> > priv->abyBBVGA[2] = 0x10;
> > priv->abyBBVGA[3] = 0x10;
> > - bb_read_embedded(priv, 0xE7, &byData);
> > - if (byData == 0x1C)
> > + bb_read_embedded(priv, 0xE7, &data);
>
> It might be nice to figure out what these register values are
> and use #defines instead of hard coded values like 0xE7

Hi Joe,
Thanks, I'm going to investigate these numbers.

tommaso
>
> > + if (data == 0x1C)
> > bb_write_embedded(priv, 0xE7, priv->abyBBVGA[0]);
>
> etc...
>

\
 
 \ /
  Last update: 2021-11-13 10:17    [W:0.036 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site