lkml.org 
[lkml]   [2021]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tipc: check for null after calling kmemdup
On Thu, 11 Nov 2021 19:06:18 -0500 Jon Maloy wrote:
> On 11/11/21 15:59, Tadeusz Struk wrote:
> > kmemdup can return a null pointer so need to check for it, otherwise
> > the null key will be dereferenced later in tipc_crypto_key_xmit as
> > can be seen in the trace [1].

> > [1] https://syzkaller.appspot.com/bug?id=bca180abb29567b189efdbdb34cbf7ba851c2a58
> >
> > Reported-by: Dmitry Vyukov <dvyukov@google.com>
> > Signed-off-by: Tadeusz Struk <tadeusz.struk@linaro.org>
> > ---
> > net/tipc/crypto.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/net/tipc/crypto.c b/net/tipc/crypto.c
> > index dc60c32bb70d..988a343f9fd5 100644
> > --- a/net/tipc/crypto.c
> > +++ b/net/tipc/crypto.c
> > @@ -597,6 +597,11 @@ static int tipc_aead_init(struct tipc_aead **aead, struct tipc_aead_key *ukey,
> > tmp->cloned = NULL;
> > tmp->authsize = TIPC_AES_GCM_TAG_SIZE;
> > tmp->key = kmemdup(ukey, tipc_aead_key_size(ukey), GFP_KERNEL);
> > + if (!tmp->key) {
> > + free_percpu(tmp->tfm_entry);
> > + kfree_sensitive(tmp);
> > + return -ENOMEM;
> > + }

> Acked-by: Jon Maloy <jmaloy@redhat.com>

Hm, shouldn't we free all the tfm entries here?

\
 
 \ /
  Last update: 2021-11-13 05:14    [W:0.082 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site