Messages in this thread | | | Date | Fri, 12 Nov 2021 20:59:21 +0000 | From | Yazen Ghannam <> | Subject | Re: [PATCH v6 3/5] EDAC/amd64: Extend family ops functions |
| |
On Thu, Nov 11, 2021 at 09:53:32PM +0530, Chatradhi, Naveen Krishna wrote:
... > > > struct low_ops { > > > - int (*early_channel_count) (struct amd64_pvt *pvt); > > > + int (*early_channel_count) (struct amd64_pvt *pvt); > > > void (*map_sysaddr_to_csrow) (struct mem_ctl_info *mci, u64 sys_addr, > > > struct err_info *); > > > - int (*dbam_to_cs) (struct amd64_pvt *pvt, u8 dct, > > > + int (*dbam_to_cs) (struct amd64_pvt *pvt, u8 dct, > > > unsigned cs_mode, int cs_mask_nr); > > > + void (*prep_chip_select) (struct amd64_pvt *pvt); > > That name should be "prep_chip_selects" - plural. > Got it. > > > > > + void (*get_base_mask) (struct amd64_pvt *pvt); > > > + void (*get_misc_regs) (struct amd64_pvt *pvt); > > > + void (*get_mc_regs) (struct amd64_pvt *pvt); > > > + int (*populate_csrows) (struct mem_ctl_info *mci); > > > + void (*get_umc_err_info) (struct mce *m, struct err_info *err); > > WARNING: Unnecessary space before function pointer arguments > > #652: FILE: drivers/edac/amd64_edac.h:470: > > + int (*early_channel_count) (struct amd64_pvt *pvt); > > > > WARNING: Unnecessary space before function pointer arguments > > #656: FILE: drivers/edac/amd64_edac.h:473: > > + int (*dbam_to_cs) (struct amd64_pvt *pvt, u8 dct, > > > > WARNING: Unnecessary space before function pointer arguments > > #658: FILE: drivers/edac/amd64_edac.h:475: > > + void (*prep_chip_select) (struct amd64_pvt *pvt); > > > > WARNING: Unnecessary space before function pointer arguments > > #659: FILE: drivers/edac/amd64_edac.h:476: > > + void (*get_base_mask) (struct amd64_pvt *pvt); > > > > WARNING: Unnecessary space before function pointer arguments > > #660: FILE: drivers/edac/amd64_edac.h:477: > > + void (*get_misc_regs) (struct amd64_pvt *pvt); > > > > WARNING: Unnecessary space before function pointer arguments > > #661: FILE: drivers/edac/amd64_edac.h:478: > > + void (*get_mc_regs) (struct amd64_pvt *pvt); > > > > WARNING: Unnecessary space before function pointer arguments > > #662: FILE: drivers/edac/amd64_edac.h:479: > > + int (*populate_csrows) (struct mem_ctl_info *mci); > > > > WARNING: Unnecessary space before function pointer arguments > > #663: FILE: drivers/edac/amd64_edac.h:480: > > + void (*get_umc_err_info) (struct mce *m, struct err_info *err); > > > > total: 0 errors, 8 warnings, 507 lines checked > > > > > > Please integrate scripts/checkpatch.pl into your patch creation > > workflow. Some of the warnings/errors *actually* make sense. > I have noticed these warnings. As there were previous definitions, i > continued with similar indentation. Will address all of them. > >
I've seen the same warning in some of my patches, but I've ignored it for readability. I'll need to make changes there too. :/
Thanks, Yazen
| |