Messages in this thread | | | Subject | Re: [PATCH bpf] samples: bpf: fix summary per-sec stats in xdp_sample_user | From | patchwork-bot+netdevbpf@kernel ... | Date | Fri, 12 Nov 2021 20:50:07 +0000 |
| |
Hello:
This patch was applied to bpf/bpf.git (master) by Daniel Borkmann <daniel@iogearbox.net>:
On Thu, 11 Nov 2021 22:57:03 +0100 you wrote: > sample_summary_print() uses accumulated period to calculate and > display per-sec averages. This period gets incremented by sampling > interval each time a new sample is formed, and thus equals to the > number of samples collected multiplied by this interval. > However, the totals are being calculated differently, they receive > current sample statistics already divided by the interval gotten as > a difference between sample timestamps for better precision -- in > other words, they are being incremented by the per-sec values each > sample. > This leads to the excessive division of summary per-secs when > interval != 1 sec. It is obvious pps couldn't become two times > lower just from picking a different sampling interval value: > > [...]
Here is the summary with links: - [bpf] samples: bpf: fix summary per-sec stats in xdp_sample_user https://git.kernel.org/bpf/bpf/c/b51a6682d432
You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
| |