lkml.org 
[lkml]   [2021]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [External] : Re: [PATCH] net: sched: sch_netem: Refactor code in 4-state loss generator
On Fri, 12 Nov 2021 17:57:08 +0000
Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> wrote:

> Hi Stephen,
>
> Yes, you are correct.
>
> To match the convention mapping should be like this instead:
>
> State 3 ---> LOST_IN_BURST_PERIOD
> State 4 ---> LOST_IN_GAP_PERIOD
>
>
> Thanks,
> Harshit
> ________________________________
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Friday, November 12, 2021 9:42 PM
> To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> Cc: Jamal Hadi Salim <jhs@mojatatu.com>; Cong Wang <xiyou.wangcong@gmail.com>; Jiri Pirko <jiri@resnulli.us>; David S. Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; netdev@vger.kernel.org <netdev@vger.kernel.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; yangyingliang@huawei.com <yangyingliang@huawei.com>
> Subject: [External] : Re: [PATCH] net: sched: sch_netem: Refactor code in 4-state loss generator
>
> On Thu, 11 Nov 2021 23:14:47 -0800
> Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> wrote:
>
> > Fixed comments to match description with variable names and
> > refactored code to match the convention as per [1].
> > [1] S. Salsano, F. Ludovici, A. Ordine, "Definition of a general
> > and intuitive loss model for packet networks and its implementation
> > in the Netem module in the Linux kernel"
> >
> > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
>
> I wonder if this was changed accidently by this commit
> Commit: a6e2fe17eba4 ("sch_netem: replace magic numbers with enumerate")
>

Could you resend with updated commit message and Fixes tag?

\
 
 \ /
  Last update: 2021-11-12 20:25    [W:0.061 / U:2.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site