Messages in this thread | | | From | Linus Torvalds <> | Date | Fri, 12 Nov 2021 11:16:14 -0800 | Subject | Re: [PATCH] tools/lib/lockdep: drop liblockdep |
| |
On Fri, Nov 12, 2021 at 7:16 AM Sasha Levin <sashal@kernel.org> wrote: > > TL;DR: While a tool like liblockdep is useful, it probably doesn't > belong within the kernel tree.
I have eagerly applied this patch, because I wasn't too happy with that thing in the first place.
However - I do note that there's signs of liblockdep in the tools/include/ directory still.
Some of those headers may now be dead, and should be removed, but I didn't end up trying to figure it out, so I left them alone.
This stupid shell command
git grep -il liblockdep tools/include/ | sed 's:tools/include/::' | while read i; do echo; echo $i:; echo; git grep $i tools/ ; done
seems to say that yes, the <linux/module.h> header in the tools directory is still used, but the rest of them seem to only reference other dead headers.
Hmm? It would be lovely to clean those headers up too and get rid of them - because those headers are very much part of why I hated the whole liblockdep mess, and why I was so happy to immediately apply this patch..
Linus
| |