lkml.org 
[lkml]   [2021]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] KVM: x86: move guest_pv_has out of user_access section
From
Date
On Fri, 2021-11-12 at 02:54 -0500, Paolo Bonzini wrote:
> When UBSAN is enabled, the code emitted for the call to guest_pv_has
> includes a call to __ubsan_handle_load_invalid_value. objtool
> complains that this call happens with UACCESS enabled; to avoid
> the warning, pull the calls to user_access_begin into both arms
> of the "if" statement, after the check for guest_pv_has.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Acked-by: David Woodhouse <dwmw@amazon.co.uk>

Thanks. I found a bunch of those objtool warnings during my original
experimentation and testing, but clearly missed that one. I'll turn on
CONFIG_UBSAN.


[unhandled content-type:application/pkcs7-signature]
\
 
 \ /
  Last update: 2021-11-12 09:12    [W:0.059 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site