lkml.org 
[lkml]   [2021]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] dt-bindings:iio:filter: add admv8818 doc
On Tue, 9 Nov 2021 14:31:26 +0200
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:

> Add device tree bindings for the ADMV8818 Filter.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> .../bindings/iio/filter/adi,admv8818.yaml | 78 +++++++++++++++++++
> 1 file changed, 78 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml b/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml
> new file mode 100644
> index 000000000000..d581e236dbdc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml
> @@ -0,0 +1,78 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/filter/adi,admv8818.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ADMV8818 Digitally Tunable, High-Pass and Low-Pass Filter
> +
> +maintainers:
> + - Antoniu Miclaus <antoniu.miclaus@analog.com>
> +
> +description: |
> + Fully monolithic microwave integrated circuit (MMIC) that
> + features a digitally selectable frequency of operation.
> + The device features four independently controlled high-pass
> + filters (HPFs) and four independently controlled low-pass filters
> + (LPFs) that span the 2 GHz to 18 GHz frequency range.
> +
> + https://www.analog.com/en/products/admv8818.html
> +
> +properties:
> + compatible:
> + enum:
> + - adi,admv8818
> +
> + reg:
> + maxItems: 1
> +
> + spi-max-frequency:
> + maximum: 10000000
> +
> + clocks:
> + description:
> + Definition of the external clock.
> + minItems: 1
> +
> + clock-names:
> + items:
> + - const: "rf_in"

Is this what we'd normally think of as a clock signal? I'd not expect
a nice squarewave on that pin for example so this seems an odd way to
define it.

> +
> + clock-output-names:
> + maxItems: 1
> +
> + adi,bw-hz:
> + description:
> + Allows the user to increase the Bandpass Filter (BPF) bandwidth
> + in Hz. Normally when invoked by the clk notifier, the driver
> + sets the HPF cutoff close below the frequency and the LPF cutoff
> + close above the frequency, and thus creating a BPF.

I don't understand this item at all. Why do we need a control to
basically change how the other filter parameters are expressed?

> + $ref: /schemas/types.yaml#/definitions/uint64
> +
> + '#clock-cells':
> + const: 0
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + admv8818@0 {
> + compatible = "adi,admv8818";
> + reg = <0>;
> + spi-max-frequency = <10000000>;
> + clocks = <&admv8818_rfin>;
> + clock-names = "rf_in";
> + adi,bw-hz = /bits/ 64 <600000000>;
> + };
> + };
> +...
> +

\
 
 \ /
  Last update: 2021-11-12 18:42    [W:0.127 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site