Messages in this thread | | | Date | Fri, 12 Nov 2021 09:37:31 -0700 | From | Mathieu Poirier <> | Subject | Re: [PATCH 05/10] Coresight: Add interface for TPDM BC subunit |
| |
On Fri, Nov 12, 2021 at 05:10:38PM +0800, Jinlong wrote: > On Fri, Nov 12, 2021 at 04:42:31PM +0800, Jinlong wrote: > > [....] > > > > > > &tpdm_attr_grp, > > > > > + &tpdm_bc_attr_grp, > > > > > > > > It is quite tedious to review all these options at the same time as the core > > > > drivers. I suggest to concentrate on the base functionality for now. When that > > > > is merged we can add configuration options such as these. > > > > > > > > I am out of time for this patchset and as such will not review the remaining > > > > patches - those will have to wait for another iteration. > > > > > > > > Thanks, > > > > Mathieu > > > > > > > > > Thank your for all the comments. > > > We will update the patches. > > > > > > Thanks > > > Jinlong Mao > > > > > > > Correct the typo. > > Hi Mathieu, > > We will reduce the code changes. > There will be code changes below for next version: > > 1. coresight: add support to enable more coresight paths > 2. Basic function for TPDM(only enable/disable functions) > 3. TPDA driver > > Is that ok for you ?
Yes, that sounds much better.
Regards, Mathieu
> > > > > > > > > > > NULL, > > > > > }; > > > > > > > > > > -- > > > > > 2.17.1 > > > > >
| |