lkml.org 
[lkml]   [2021]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] of/irq: Don't ignore interrupt-controller when interrupt-map failed
On Fri, 12 Nov 2021 14:57:13 +0000,
Rob Herring <robh@kernel.org> wrote:
>
> On Fri, Nov 12, 2021 at 8:37 AM Marc Zyngier <maz@kernel.org> wrote:
> >
> > @@ -244,8 +245,14 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq)
> >
> > pr_debug(" -> imaplen=%d\n", imaplen);
> > }
> > - if (!match)
> > + if (!match) {
> > + if (intc) {
> > + pr_debug("%pOF interrupt-map failed, using interrupt-controller\n", ipar);
>
> Let's make this a WARN for !IS_ENABLED(CONFIG_PASEMI). (whatever the
> right kconfig symbol is).

I've folded this in.

M.

diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 508fb1717de3..b10f015b2e37 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -247,7 +247,13 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq)
}
if (!match) {
if (intc) {
- pr_debug("%pOF interrupt-map failed, using interrupt-controller\n", ipar);
+ /*
+ * The PASEMI Nemo is a known offender, so
+ * let's only warn for anyone else.
+ */
+ WARN(!IS_ENABLED(CONFIG_PPC_PASEMI),
+ "%pOF interrupt-map failed, using interrupt-controller\n",
+ ipar);
return 0;
}

--
Without deviation from the norm, progress is not possible.
\
 
 \ /
  Last update: 2021-11-12 16:27    [W:0.055 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site