Messages in this thread | | | From | "Lad, Prabhakar" <> | Date | Fri, 12 Nov 2021 14:17:23 +0000 | Subject | Re: [PATCH v3 3/6] pinctrl: renesas: pinctrl-rzg2l: Add helper functions to read/write pin config |
| |
Hi Geert,
Thank you for the review.
On Fri, Nov 12, 2021 at 2:06 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > On Wed, Nov 10, 2021 at 11:46 PM Lad Prabhakar > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > Add helper functions to read/read modify write pin config. > > > > Switch to use helper functions for pins supporting PIN_CONFIG_INPUT_ENABLE > > capabilities. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > v2->v3 > > * Dropped duplicate masking in rzg2l_read_pin_config > > * Dropped port_pin flag > > * Dropped spinlocks around read/write > > You do need the spinlock in the read-modify-write case. > Ouch I mistook your comment of dropping the lock entirely! > No worries, I'll add it back while applying. > Thank you.
Cheers, Prabhakar
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > i.e. will queue in renesas-pinctrl-for-v5.17. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
| |